Repository navigation
Add enhanced flag to get_lyrics_by_song_id - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
enhancedargument toget_lyrics_by_song_id(). Servers that implement the OpenSubsonic lyrics v2 extension (Navidrome 0.63+) return word-levelcueLinedata only when the client sendsenhanced=true. The response types already modelCueLineandCue; the connection just never asked for them.The default is
False, which omits the parameter, so existing callers get exactly the v1 response.Checked against Navidrome 0.64.2, same track:
enhanced=True: 58 lines, 58 cueLinesThe enhanced response parses into
StructuredLyrics.cue_line, covered by new tests.Full test suite: 153 passed.
Context: music-assistant/server needs this for word-by-word lyrics, see https://github.com/orgs/music-assistant/discussions/5345. I can follow up with the server side once this is released.