Skip to content

Add enhanced flag to get_lyrics_by_song_id - #9

Merged
khers merged 1 commit into
khers:mainfrom
Schnurzel700:feat/enhanced-lyrics
Nov 21, 2026
Merged

khers merged 1 commit into
khers:mainfrom
Schnurzel700:feat/enhanced-lyrics

Conversation

@Schnurzel700

Copy link
Copy Markdown

Adds an optional enhanced argument to get_lyrics_by_song_id(). Servers that implement the OpenSubsonic lyrics v2 extension (Navidrome 0.63+) return word-level cueLine data only when the client sends enhanced=true. The response types already model CueLine and Cue; the connection just never asked for them.

The default is False, which omits the parameter, so existing callers get exactly the v1 response.

Checked against Navidrome 0.64.2, same track:

  • without the flag: 58 lines, 0 cueLines
  • with enhanced=True: 58 lines, 58 cueLines

The enhanced response parses into StructuredLyrics.cue_line, covered by new tests.

Full test suite: 153 passed.

Context: music-assistant/server needs this for word-by-word lyrics, see https://github.com/orgs/music-assistant/discussions/5345. I can follow up with the server side once this is released.

@khers khers left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@khers
khers merged commit d349881 into khers:main Nov 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants